[SAMBAD-228] 모임원 답변 등록 시 리스트 요청 규격 수정 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkjsw17
approved these changes
Aug 7, 2024
Comment on lines
50
to
55
| List<Long> answerIds = request.answerIds(); | ||
| List<MeetingAnswer> meetingAnswers = answerIds.stream() | ||
| .map(answerId -> answerService.getById(questionId, answerId)) | ||
| .map(answer -> new MeetingAnswer(meetingQuestion, answer, loginMember)) | ||
| .toList(); | ||
| meetingAnswers.forEach(meetingAnswerRepository::save); |
There was a problem hiding this comment.
원자적인 작업으로 수행될 수 있는 메서드로 빼는게 좋아보이는데, 어떻게 생각하시나요?!
There was a problem hiding this comment.
메서드가 무거워 보이긴 하네요. 분리 했습니다! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)
📝 개요